The Night Market Submarine no longer returns any objects placed inside of them.
How to reproduce:
Go to Winter 17, wait till 5 pm. Enter the submarine or the mermaid boat, and place a chest containing items in it. Then, sleep. Head to the shore of the beach, and see the problem.
Expected Behavior: (how 1.5 worked)
A chest shows up on the shore of the beach containing your items
Actual Behavior:
The items and chest get deleted. This can be verified by placing tools inside the chest, and then when you sleep from the 18th-19th the overnight check looking for tools will notice that they're gone and will put them in the lost and found.
Now, I haven't looked at the code for 1.6 yet but I was looking at this routine for 1.5 and so I'll explain how the process works:
In Game1._newDayAfterFade, there exists the check
if (IsMasterGame)
{
if (currentSeason.Equals("winter") && dayOfMonth == 18)
{ blah blah Utility.transferPlacedObjectsFromOneLocationToAnother submarine and mermaid house}
Now, this has to still be functional because if it was not called the chest would just remain in the submarine and not get deleted.
A summary of transferPlacedObjectsFromOneLocationToAnother is that it goes object by object and puts it in a list. If it's a chest, it puts every item inside the object in the list as well. This also has to be functioning, at least enough to be calling source.objects.Remove(item). With this list, it calls createOverflowChest. (still in Utility)
A summary of createOverflowChest is that it figures out what chest layout the items need to be in. Ultimately, its end result is having a list of chests each containing the items that were transferred. Finally it calls _placeOverflowChestInNearbySpace. I'm honestly tied between whether I think the bug is in create or in place.
A summary of _placeOverflowChestInNearbySpace is that it goes out in a spiral from the center point and looks for any non-occupied, totally clear and placable, non-water spots. Once its either found one or checked 100 tiles it places the chest there.
At some point in this process after it deletes the objects it fails to place the new chests. I'm going to guess that some part of how the game places down chests has changed and this wasn't updated, but this is an entirely unfounded guess.
(I guess I'll say that I'm on 1.6.0 and on Mac and English, and I've attached a save file on Winter 17 with the 50 wood needed to craft a chest so that you can see it yourself. Because I don't have the patience to actually sleep three seasons, I used CJB to set my day to Winter 15 and slept and then slept on vanilla to the 17th)