Solved [Bug] v1.5.5 - GOG: Translated "fruitTrees.xnb" files cause issues

[MysticTempest]

Huge thanks to @Quirinea; who helped out with troubleshooting/testing on the GOG side of things.

Bug:
Banana/Mango fruit trees are planted with corrupt data in Non-English languages on the GOG version(v1.5.4/v1.5.5)

Cause:
There are translated versions of the original Content/Data/fruitTrees.xnb file.
Ex. Content/Data/fruitTrees.{language_code}.xnb

None of these translated versions have the data for the Banana or Mango fruit trees. This causes the planted trees to be very broken.

Fix:
As with the Steam version.
Remove the translated 'fruitTrees' files from the GOG version; as this file only holds the data for growth. The translated text for those trees is handled by their corresponding ObjectInformation.{language_code}.xnb files.

So we can just default to the single Content/Data/fruitTrees.xnb file for all languages on GOG; just like it's done in the Steam version.


Save for testing(added on the 1st thread linked below):

https://forums.stardewvalley.net/attachments/brptmango_290076558-zip.6360/

Sources:
Initially reported here for v1.5.4: https://forums.stardewvalley.net/th...glitch-about-banana-tree-and-mango-tree.4623/
And, tried to get a bit more eyes on it in the beta:

https://forums.stardewvalley.net/threads/stardew-valley-1-5-5-technical-update-beta.8893/post-52732

 

[Mr. Podunkian]

This must be mod related. We don't ship the game on any platform with localized fruitTrees data files because they don't contain any localized content.

 

[MysticTempest]

This must be mod related. We don't ship the game on any platform with localized fruitTrees data files because they don't contain any localized content.

I'm playing on Steam; so I'd have to defer to some of the GOG users for testing again.

However, the files were on the Steam version of the game; until they were removed in v1.4 of SDV.
I guess it's possible that legacy files could still be around from an earlier install. As I'm unsure if GOG has any file cleanup system like Steam.


@Quirinea; if you or another GOG user reading this; could hop in. And, retest with a clean install to a new folder. Just to help verify that GOG no longer ships those files; it'd be appreciated.

 

[Quirinea]

This must be mod related. We don't ship the game on any platform with localized fruitTrees data files because they don't contain any localized content.

It is NOT mod related. All mod files are in the folder "Mods" (and I've never used any "xnb-mods"). But...

Now I can see the reason: The culprit files are:
-rw-r--r-- 1 laura laura 310 tammi 27 2019 fruitTrees.en.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.de-DE.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.zh-CN.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.tr-TR.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.ru-RU.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.pt-BR.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.ko-KR.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.ja-JP.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.it-IT.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.hu-HU.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.fr-FR.xnb.not
-rw-r--r-- 1 laura laura 310 maali 23 2019 fruitTrees.es-ES.xnb.not
-rw-rw-r-- 1 laura laura 332 joulu 5 21:10 fruitTrees.xnb

(tammi = tammikuu = January, maali = maaliskuu =March, joulu = joulukuu = December)
I installed the new version on 5. December. So I can see, those
The installation does just overwrite the previous files, it obviously does not remove anything. So if file structure changes, changing a filename or leaving obsolete files, they stay as residue.
So the problem is not the shipping itself, it's the installation that does not check for obsolete stuff.
And as there are scores of files, in umpteen folders, it's hard to check manually. Or guess that you should do that, for the matter. Of course removing the old version completely and backing up the mods would do the trick.
Hmmm. Actually it seems those fruit trees are not the only extra files that there are.

 

[Mr. Podunkian]

My mistake! As you said, it's an issue of GOG not properly deleting files that were removed as part of an update -- if you delete the Content folder and revalidate the installation to redownload it, the problem will most likely resolve itself.

 

[Quirinea]

My mistake! As you said, it's an issue of GOG not properly deleting files that were removed as part of an update -- if you delete the Content folder and revalidate the installation to redownload it, the problem will most likely resolve itself.

Yeah. Though I suppose it is enough to do what I have done now -- added an extra ending (that "not" to those files that are not from the last update. Actually the trick would be to rename the folder "StardewValley" to something else before updating, then move the mods and clean the mess. The problem with cleaning the mess manually is always that I'm afraid to remove something I did not want to (mods and own tests), so I don't dare to just use "the rm-editor" (old joke for calling "rm file" instead of "em file" (for the editor emacs)).
I now went through the files and marked off anything that was not from the latest install or something I had added personally (working with my translation mod).