Raphaël Ambrosius Costeau
Greenhorn
Description:
On the SocialPage UI, single male farmers are incorrectly displayed with the female relationship status (e.g., "single_female") across all gendered languages (Spanish, Portuguese, Italian, Russian, custom localizations, etc.).
Root Cause:
In SocialPage.cs, inside drawFarmerSlot(), the code attempts to extract male and female statuses by calling .Split('/') on the female key SocialPage_Relationship_Single_Female:
Why this breaks localizations:
In drawFarmerSlot(), check gender and load SocialPage_Relationship_Single_Male directly instead of splitting SocialPage_Relationship_Single_Female:
On the SocialPage UI, single male farmers are incorrectly displayed with the female relationship status (e.g., "single_female") across all gendered languages (Spanish, Portuguese, Italian, Russian, custom localizations, etc.).
Root Cause:
In SocialPage.cs, inside drawFarmerSlot(), the code attempts to extract male and female statuses by calling .Split('/') on the female key SocialPage_Relationship_Single_Female:
Code:
string text = (!Game1.content.ShouldUseGenderedCharacterTranslations()) ? Game1.content.LoadString("Strings\\StringsFromCSFiles:SocialPage_Relationship_Single_Female") : ((gender == Gender.Male) ? Game1.content.LoadString("Strings\\StringsFromCSFiles:SocialPage_Relationship_Single_Female").Split('/', StringSplitOptions.None)[0] : Game1.content.LoadString("Strings\\StringsFromCSFiles:SocialPage_Relationship_Single_Female").Split('/', StringSplitOptions.None).Last<string>());- Separate Keys: Official and custom translators define two separate standalone keys in JSON: SocialPage_Relationship_Single_Male and SocialPage_Relationship_Single_Female without slashes /. Because there is no / in SocialPage_Relationship_Single_Female, .Split('/')[0] evaluates to the full female string for male farmers.
- Catch-22 Workaround: If translators try to add a slash to SocialPage_Relationship_Single_Female (e.g. "MaleStatus/FemaleStatus"), it fixes drawFarmerSlot(), BUT breaks all single female NPCs in _SetCharacter(). NPC profiles load SocialPage_Relationship_Single_Female directly without splitting it, causing female NPCs to display "MaleStatus/FemaleStatus" in their profile menu.
In drawFarmerSlot(), check gender and load SocialPage_Relationship_Single_Male directly instead of splitting SocialPage_Relationship_Single_Female:
Code:
string text = ((gender == Gender.Male) ? Game1.content.LoadString("Strings\\StringsFromCSFiles:SocialPage_Relationship_Single_Male") : Game1.content.LoadString("Strings\\StringsFromCSFiles:SocialPage_Relationship_Single_Female"));