CandyNim
Tiller
Bug: Placing targtted bait into a crab pot doesn't impact the odds of the crab pot.
Code Analysis: In CrabPot.DayUpdate, the game loops through all fish. Once it confirms that the fish is supposed to be in this crab pot, it enters the fish selection. If the farmer has Mariner, it adds the fish to the
marinerList, and otherwise it performs the probability based fish roll - with probability boosted by baitTargetFish. With Mariner, then, the fish simply becomes a random choice from the marinerList, completely avoiding any baitTargetFish reference.
Suggested Fix: The simplest solution in my mind is to add the fish twice to the list -
if (baitTargetFish != null && baitTargetFish == v.Key) {marinerList.Add(v.Key);}
That would make targeted bait (almost) double the fish odds; which doesn't perfectly align with how it impacts non-crab pot fishing, but still gives it an impact.
Code Analysis: In CrabPot.DayUpdate, the game loops through all fish. Once it confirms that the fish is supposed to be in this crab pot, it enters the fish selection. If the farmer has Mariner, it adds the fish to the
marinerList, and otherwise it performs the probability based fish roll - with probability boosted by baitTargetFish. With Mariner, then, the fish simply becomes a random choice from the marinerList, completely avoiding any baitTargetFish reference.
Suggested Fix: The simplest solution in my mind is to add the fish twice to the list -
if (baitTargetFish != null && baitTargetFish == v.Key) {marinerList.Add(v.Key);}
That would make targeted bait (almost) double the fish odds; which doesn't perfectly align with how it impacts non-crab pot fishing, but still gives it an impact.