Issue Game crashes when I go near my fish ponds.

[yield133]

Hello! My game crashes whenever I try to go near my fish ponds. It was running fine just yesterday, but for some reason today it started having issues today. I tried to look at the log myself, and I think it may have something to do with alternative textures, but I can't make head nor tail of it. I also have a TON of mods, because I was trying to do a mega-modded playthrough (and basically seeing just how many mods my game can handle), so I'm sorry if it looks a little chaotic!

Here's my Smapi log: https://smapi.io/log/3817f6ec21bf47079bbd934d2ac12f28

 

[MysticTempest]

Hey, thanks for the log.

So, this error for the fish ponds happens when an item that isn't normally supposed to be in a fish pond ends up there.

I see it a lot with JsonAssets; since their IDs aren't set in stone.
Though, I do see a few other Fish-related mods that you have; like Margo, which can potentially also cause the same problem.

20:51:17    ERROR    SMAPI    An error occurred in the overridden draw loop: NullReferenceException: Object reference not set to an instance of an object.
   at StardewValley.Buildings.FishPond._GetNeededItemData() in stardewvalley\Farmer\Farmer\Buildings\FishPond.cs:line 920
   at StardewValley.Buildings.FishPond.HasUnresolvedNeeds() in stardewvalley\Farmer\Farmer\Buildings\FishPond.cs:line 906
   at StardewValley.Buildings.FishPond.draw(SpriteBatch b) in stardewvalley\Farmer\Farmer\Buildings\FishPond.cs:line 1265
   at AlternativeTextures.Framework.Patches.GameLocations.FarmPatch.BaseDrawReversePatch_ReversePatchedByUnknown(BuildableGameLocation __instance, SpriteBatch b)
   at AlternativeTextures.Framework.Patches.GameLocations.FarmPatch.DrawPrefix(Farm __instance, TemporaryAnimatedSprite ___shippingBinLid, SpriteBatch b) in C:\Users\Floogen\Documents\GitHub Repos\AlternativeTextures\AlternativeTextures\Framework\Patches\GameLocations\FarmPatch.cs:line 110
   at StardewValley.Farm.draw_PatchedBy<PeacefulEnd.AlternativeTextures>(Farm this, SpriteBatch b)
   at StardewModdingAPI.Framework.SGame.DrawImpl_PatchedBy<tlitookilakin.AeroCore>(SGame this, GameTime gameTime, RenderTarget2D target_screen)
   at StardewModdingAPI.Framework.SGame._draw(GameTime gameTime, RenderTarget2D target_screen)

If you post your save folder here, I'll take a look at the broken item in the fish pond, and remove it:

Saves - Stardew Valley Wiki

The game saves progress when the in-game day ends, i.e., when the farmer goes to bed, collapses from exhaustion, or collapses at 2am. All progress during a day is lost if the player quits the game without ending the day. In multiplayer, the game saves after all players click through the prompts...

stardewvalleywiki.com

--
Edit:
Just to add I'm seeing a ton of these JA ID changes: https://smapi.io/log/3817f6ec21bf47...~warn~error~alert~critical&Filter=changing+id

TRACE Json Assets Changing ID: Everlasting Vanilla from ID 3770 to 3879
So, it's very likely JA like I mentioned earlier.

And, a quick example of a previous user with the same sort of issue: https://forums.stardewvalley.net/th...-try-to-walk-to-my-fish-pond.15293/post-89883

 

[yield133]

Thanks for the quick reply! Here's my save. Any suggestions on what I should do about all these other changing ids? I want to try to avoid something like this happening again.

 

[MysticTempest]

Thanks for the quick reply! Here's my save. Any suggestions on what I should do about all these other changing ids? I want to try to avoid something like this happening again.

Thanks, I can make do with the main save, but could you also send the JA objects file?
Inside your save folder; there's a sub-folder called "JsonAssets", and inside should be the current, JA object IDs: ids-objects.json

As for managing the changing IDs; not a whole to do. It's an inherent property of the way JA works.
Some people recommend not adding any new JA mods after a play-through starts, but it's not a guarantee.
SpaceChase's DGA is the successor to supposedly fix that shuffling, but there's still a lot of mods that haven't updated to it.

 

[yield133]

Ah, ok, gotcha. Here's my JA objects file.

 

[MysticTempest]

Ah, ok, gotcha. Here's my JA objects file.

Thanks, so fixing the fish ponds was easy.
But, I've been having trouble verifying in-game; as SpaceCore keeps preventing the save from loading.
Even before editing I was getting a few errors about duplicate recipes, and such.
Since, I don't have the same mods as you; that could be the root cause.

But, give this edited save a try; hopefully it'll work for you, since you have all the necessary mods there.
If not; I'll try, and think of something else.


In terms of what I edited though.
For the fish ponds I edited the following:

"Cactus Soda":3354, => "Butterfish":3343,
"Snatcher Worm":4809, => "Butterfish":3343,
"Semisweet Bakers Chocolate":4768, => "Snatcher Worm":4809,
"Strawberry Fruit Syrup":4902 => "Gemfish":3952,
"Wheatberry Mushroom Starter":5169, => reset fish pond

The first section is what was in your fish ponds based on the current JA IDs, and then I switched them over to the secondary list based on their outputs.
Not sure about the last one; so I just emptied it.

 

[yield133]

The fish ponds are fine now and the game's not crashing anymore! Thank you so much! Another thing I've noticed now is that a lot of my fences aren't showing up, they're just yellow blocks of color. Not sure if this is caused by a similar issue as before. Smapi is saying: LooseSprits\Fence4897 could not be loaded!

Here's the log: https://smapi.io/log/579506ae20964714a1183d7a7d6343bf

 

[MysticTempest]

The fish ponds are fine now and the game's not crashing anymore! Thank you so much! Another thing I've noticed now is that a lot of my fences aren't showing up, they're just yellow blocks of color. Not sure if this is caused by a similar issue as before. Smapi is saying: LooseSprits\Fence4897 could not be loaded!

Here's the log: https://smapi.io/log/579506ae20964714a1183d7a7d6343bf

Awesome, glad that you were able to load it up, and confirm the fishpond fixes!

The fences; I'm not too sure. I do see a few of the same errors in your original log.
They do reference JA; so it might be a similar issue. Though, it's a little weird how they're typo'd to say "sprits" instead of "sprites".
Makes me wonder if it's a broken CP attempting to overwrite them.

Honestly, as I mentioned before. You may want to try, and look into the JA mods, and see if they've been updated to use DGA.
That'd cut back at least on some of the ID shuffling; if that's the case again.

20:06:48    ERROR    Json Assets    LooseSprits\Fence4298 could not be loaded!
    repeats 10 times
20:06:52    ERROR    Json Assets    LooseSprits\Fence3479 could not be loaded!
    repeats 11 times
20:07:04    ERROR    Json Assets    LooseSprits\Fence4298 could not be loaded!
    repeats 9 times
20:07:06    ERROR    Json Assets    LooseSprits\Fence4899 could not be loaded!
    repeats 6 times
20:07:06    TRACE    SMAPI    Content Patcher edited LooseSprites/Fence1 (for the 'Stardew Valley Expanded' content pack).
20:07:06    TRACE    SMAPI    Content Patcher edited LooseSprites/Fence1 (for the 'Vibrant Pastoral Recolor' content pack).
20:07:06    TRACE    SMAPI    Content Patcher edited LooseSprites/Fence1 (for the 'Vibrant Pastoral for SVE' content pack).
20:08:29    TRACE    SMAPI    Json Assets loaded asset 'LooseSprites/Fence5322'.

 

[yield133]

Ahh, after some investigating, I realized that I had different versions of the same fence mod. So I uninstalled all of them and reinstalled only one. I also ended up bombing the glitched fences to get rid of them since the game wasn't allowing me to pickaxe or axe them. Looks like everything is running fine now. Thank you again for all your help!