PC [BUG] Tapped Mahogany tree turned to Mushroom tree

[margotbean]

PC v1.5
Singleplayer

Playing using SMAPI, I had a Mahogany tree tapped with a Heavy Tapper turn into a Mushroom Tree on Fall 11.
It's shown in the lower left corner, the tapper still has sap in it.

 

[LRangerR]

This isn't a bug. Any full grown tree has a small chance to turn into a mushroom tree during fall.

 

[dubesor]

trees turning into mushroom trees is normal since starting fall 2nd the game checks tiles and sometimes turns a fully grown tree into a mushroom tree. However I am not sure if it's supposed to do that on Trees that have a tapper on them - in the compiled code it looks like it's supposed to ignore tapped trees (&& !(t as Tree).tapped) but I could be wrong.

 

[margotbean]

This isn't a bug. Any full grown tree has a small chance to turn into a mushroom tree during fall.

The relevant code is in StardewValley.Farm::DayUpdate

    if (terrainFeatures.Count() > 0 && Game1.currentSeason.Equals("fall") && Game1.dayOfMonth > 1 && Game1.random.NextDouble() < 0.05)
    {
        for (int tries = 0; tries < 10; tries++)
        {
            TerrainFeature t = terrainFeatures.Pairs.ElementAt(Game1.random.Next(terrainFeatures.Count())).Value;
            if (t is Tree && (int)(t as Tree).growthStage >= 5 && !(t as Tree).tapped)
            {
                (t as Tree).treeType.Value = 7;
                (t as Tree).loadSprite();
                break;
            }
        }
    }

Starting Fall 2, any untapped common tree has a 5% chance of turning into a Mushroom Tree. If you're unsure of the details, you can always check the wiki.

Thats mean my sweet apple tree would turn into a big mushroom? Oh my.

Fruit Trees are not "Tree" in the code but rather "FruitTree", so they will never turn into Mushroom Trees (that wouldn't be a very nice thing for the game to do).

trees turning into mushroom trees is normal since starting fall 2nd the game checks tiles and sometimes turns a fully grown tree into a mushroom tree. However I am not sure if it's supposed to do that on Trees that have a tapper on them - in the compiled code it looks like it's supposed to ignore tapped trees (&& !(t as Tree).tapped) but I could be wrong.

Either a Heavy Tapper isn't properly registering as a tapper, or the Mahogany Tree isn't properly registering as a "tree", or something else entirely, that the developers can figure out better than I can.

Cheers!

 

[LRangerR]

Either a Heavy Tapper isn't properly registering as a tapper, or the Mahogany Tree isn't properly registering as a "tree", or something else entirely, that the developers can figure out better than I can.

Cheers!

Ah, I understand now. Good find!

 

[BlaDe]

Either a Heavy Tapper isn't properly registering as a tapper, or the Mahogany Tree isn't properly registering as a "tree", or something else entirely, that the developers can figure out better than I can.

Found it.

Tree::dayUpdate
            if (this.tapped.Value)
            {
                Object tile_object = environment.getObjectAtTile((int)tileLocation.X, (int)tileLocation.Y);
                if (tile_object == null || !tile_object.bigCraftable || (int)tile_object.parentSheetIndex != 105)
                {
                    this.tapped.Value = false;
                }
            }

This section hasnt been updated for a heavy tapper (id 264)