BlaDe
Farmer
There is a timing issue that causes inconsistencies with money earned if you choose a professions that increases value of items that were shipped that day.
If you ship a single regular quality melon(250g), and level up to 5 overnight and chose the Tiller profession (add 10% to crops), the shipping summary will show you earning 275g. However your funds only increase by 250g.
Funds are added to your wallet early on in Game1::_newDayAfterFade. This is before you have a chance to chose professions.
Professions and shippingMenu are queued up in Game1::showEndOfNightStuff, which is called near the end of _newDayAfterFade.
The LevelUpMenu is pushed to the front of the endOfNightMenus, so professions can be chosen before ShippingMenu is shown.
ShippingMenu uses the value of the items at the time the menu is shown, which means that any newly acquired professions influence the sale price of items shows. However this is well past the time when the funds were added to the player's wallet.
Either funds should be added after choosing professions, or the shipping summary not account for newly acquired professions.
If you ship a single regular quality melon(250g), and level up to 5 overnight and chose the Tiller profession (add 10% to crops), the shipping summary will show you earning 275g. However your funds only increase by 250g.
Funds are added to your wallet early on in Game1::_newDayAfterFade. This is before you have a chance to chose professions.
Professions and shippingMenu are queued up in Game1::showEndOfNightStuff, which is called near the end of _newDayAfterFade.
The LevelUpMenu is pushed to the front of the endOfNightMenus, so professions can be chosen before ShippingMenu is shown.
ShippingMenu uses the value of the items at the time the menu is shown, which means that any newly acquired professions influence the sale price of items shows. However this is well past the time when the funds were added to the player's wallet.
Either funds should be added after choosing professions, or the shipping summary not account for newly acquired professions.